improvements on card type dialogs#20488
Conversation
rename: show red text when card type name used remove (:) from text field label add dialog with text field for card type name when adding new card type and with add button edit remove card title and button
|
Important Maintainers: This PR contains Strings changes
|
|
@nourhanbakry Edit: Some info: Contributing guidelines don't allow multiple commits. |
|
Also make sure to not make many commits, use rebase or use (git --amend --no-edit) to make changes in the same commit |
|
@nourhanbakry test cases are failing. kindly check it, if you need any assistance let me know |
|
The fact that there was already a PR aside, I prefer just "Name" instead of "Card type name". The "Card type name already used" string gave me an idea though. I think it would be better to use "Name already used" instead of "Deck already exists" and similar strings. |
|
Please focus heavily on quality. This needs a lot of work before it's reviewable. https://github.com/ankidroid/Anki-Android/blob/main/CONTRIBUTING.md I'll take mod action if this becomes a pattern |
Purpose / Description
Improvements on card type dialogs
Fixes
Approach
How Has This Been Tested?
Through android emulator API 33 and here are results
Checklist